checkpoint: support checkpoint create command #4484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ChengyuZhu6
force-pushed
the
checkpoint
branch
8 times, most recently
from
b6e106e to
fee41f4
Compare
ChengyuZhu6
force-pushed
the
checkpoint
branch
from
fee41f4 to
c64d77c
Compare
ChengyuZhu6
force-pushed
the
checkpoint
branch
7 times, most recently
from
292ceb4 to
c4ed970
Compare
# nerdctl run -d --name test-container ghcr.io/stargz-containers/alpine:3.13-org sleep infinity
b2a7213fd10f898f5af65493692aa2d1c18b9abd26fc477cc2c302170398987d
# nerdctl checkpoint create --leave-running=true --checkpoint-dir /tmp/test-checkpoints test-container test-checkpoint
test-checkpoint
# ls /tmp/test-checkpoints/test-checkpoint/
cgroup.img files.img ipcns-var-11.img pages-1.img tmpfs-dev-49.tar.gz.img tmpfs-dev-55.tar.gz.img
core-1.img fs-1.img mm-1.img pstree.img tmpfs-dev-52.tar.gz.img utsns-12.img
descriptors.json ids-1.img mountpoints-13.img seccomp.img tmpfs-dev-53.tar.gz.img
fdinfo-2.img inventory.img pagemap-1.img timens-0.img tmpfs-dev-54.tar.gz.img |
ChengyuZhu6
force-pushed
the
checkpoint
branch
10 times, most recently
from
05cc852 to
61e9bac
Compare
install criu in ci to test checkpoint. Signed-off-by: ChengyuZhu6 <[email protected]>
introduce taskoptions to reduce argument numbers.
Otherwise, ci would be failed by:
```
Error: pkg/taskutil/taskutil.go:51:1: argument-limit:
maximum number of arguments per function exceeded; max 12 but got 13
func NewTask(ctx context.Context, client *containerd.Client,
container containerd.Container, attachStreamOpt []string,
isInteractive, isTerminal, isDetach bool, con console.Console,
logURI, detachKeys, namespace string, detachC chan<- struct{}, checkpointDir string)
```
Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6
force-pushed
the
checkpoint
branch
from
a9bbf49 to
c0f6d57
Compare
Currently, nerdctl CI uses docker 28.0.4, while docker version 28.x has a known regression that breaks Checkpoint/Restore functionality. The issue is tracked in the moby/moby project as moby/moby#50750. Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6
force-pushed
the
checkpoint
branch
from
c0f6d57 to
060469a
Compare
|
Re-push to trigger ci, no code change. |
ChengyuZhu6
force-pushed
the
checkpoint
branch
18 times, most recently
from
adf34ca to
f3c4fb0
Compare
Signed-off-by: ChengyuZhu6 <[email protected]>
ChengyuZhu6
force-pushed
the
checkpoint
branch
from
f3c4fb0 to
627f63d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4483